…tion

This CL fixes the initialization order so that
navigation_transition_type_ is used after its value is set.

(cherry picked from commit 5eb5fbf)

Bug: 1427995
Change-Id: Idd6e2156a59123f1a0941ba0ed4fa96bc90ca2a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375797
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1122993}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4386895
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/branch-heads/5672@{#166}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}

This CL explicitly disables Native Find in Page for the NTP.

(cherry picked from commit a57b3c9)

Fixed: 1419575
Change-Id: If584fd0150ccd4e514f78565fd9e70491fafd108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4295430
Reviewed-by: David Jean <djean@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Quentin Pubert <qpubert@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1111137}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304006
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#166}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

Skip the screenshots check since the strings aren't really changed.

(cherry picked from commit 1304d60)

Bug: 1382852
Change-Id: I5853c59798afa9d674197c512b8f5838de9b1d23
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4018334
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1073146}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4044021
Reviewed-by: Ayman Almadhoun <ayman@chromium.org>
Cr-Commit-Position: refs/branch-heads/5414@{chromium#166}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}

As we support nested archives for each outer archive type (ZIP, RAR,
DMG, 7Z), we repeated a lot of code in the individual analyzers. This
CL brings that common code into one base class, for better robustness.

(cherry picked from commit 82b48b0)

Bug: 1373671
Fixed: 1426164
Change-Id: Id37f4bfd29712e899e28d5ba2df101e3bb668e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4471948
Reviewed-by: Adam Psarouthakis <psarouthakis@google.com>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1136094}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499168
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#166}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

The original intention of the code was, if there already exists
the downloaded lacros, use it, otherwise, report "there doesn't".
However, in some cases, current code unintentionally gives it try
to download and so it blocks loading.

This causes a problem that lacros is not usable for certain amount
of time, while waiting for O(min) time will resolve the issue.

This CL stops to download as originally intended. Because this
still registers the component, download in background should keep
working.

There are more rooms to be cleaned up, but that will be done
separately in later CLs.

BUG=1455070
TEST=Ran locally. Tryjob.

(cherry picked from commit 60e4f9e)

Change-Id: Iacb03ff179fec7ce9f37c9e29ff0c13cf28345ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4639328
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1161725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4648509
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#166}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}

This CL fixes the SUBQUERY used to determine whether an URL is
handled by the share extension.

As 'public.file-url' conforms to 'public.url', it must be explicitly
removed. Indeed, file URLs are not handled by the share extension.

(cherry picked from commit 293c5b9)

Bug: 1314236
Change-Id: I51acf7a955198ed0d70192c967554c1184c058cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599338
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#995084}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606070
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/5005@{chromium#166}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}

* Follow up to crrev/c/4481448 and based on crrev/c/4545857

* Add banner to be shown to a (not new) supervised profile when seeing the interstitial page for the first time

(cherry picked from commit 2b6bceb)

Bug: b/265151907,1449139
Change-Id: Idf9f50c6d584410c6fe8b94420b952a6082a5458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4556207
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Commit-Queue: Liza Bipin <mlbipin@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1148984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574902
Auto-Submit: Liza Bipin <mlbipin@google.com>
Reviewed-by: James Lee <ljjlee@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#166}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

Commits rolled:
https://dawn.googlesource.com/dawn.git/+log/f8fa217798a7..ec2cc4056373

Generated by: go/bbid/8770217330244997217

Change-Id: I82410c590258baa6d46b16c082537d073c341307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853184
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#166}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

…ubble edge to 20px"

This reverts commit 90dba61.

Reason for revert: Suspected culprit for failures on https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/84738/overview

Original change's description:
> [CR2023] Update distance from bubble close button to bubble edge to 20px
>
> This will only effect bubbles that have a header view.
>
> Bug: 1487811
> Change-Id: If9be19746f8581b08dc3e12efea22a708d179405
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902468
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204217}

(cherry picked from commit 5169926)

Bug: 1487811, 1488714
Change-Id: If600d8bf908aa90de8c5f8856e4f1c613be697f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903451
Reviewed-by: Zain Afzal <zafzal@google.com>
Auto-Submit: Zain Afzal <zafzal@google.com>
Owners-Override: Zain Afzal <zafzal@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Zain Afzal <zafzal@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1204462}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4917147
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#166}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

Uploaded by https://ci.chromium.org/b/8765401393384287313

Change-Id: I2f3bf658eb1f79b78ac7fd7e93c75e590aef30b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003123
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#166}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

…21.0.6167.10-r1 to 121-6126.0-1701694528-benchmark-121.0.6167.11-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: mobiletc-prebuild@google.com
Change-Id: I55fdb9045963fcf65c2580cdcd4ecaf64e3832f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5108097
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#166}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

It appears as though the issues we thought had been ironed out with
creating an XrInstance from the main activity had been ironed out have
not been fully ironed out, so put the behavior behind a flag again for
the mean time.

(cherry picked from commit b81a5b1)

Fixed: 1521500
Change-Id: If2b0f783516e58dde376c1992b9fab976f6b9873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238636
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1252307}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241718
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#166}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.

If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org,
yjt@google.com.


R=rubber-stamper@appspot.gserviceaccount.com

Requires-Testing: True
Change-Id: I027958e3bdd4f8a13b0cb77ae1c7222c095054f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220837
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#166}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

After the latest internal roll, performance should now be better on
Windows with HostMappedPointer enabled.

(cherry picked from commit a2cf211)

Bug: 326240401
Change-Id: I5fd9dc87a470d908ede0ea71f442fc8836335847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315982
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1263702}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323735
Cr-Commit-Position: refs/branch-heads/6312@{#166}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

This is a reland of commit 7ffff8d

This CL was reverted because the toast would show for a split second and
then transition to a hidden state. With the  new change that sets the
toast element's initial visibility to hidden, the issue does not
manifest.

Original change's description:
> [ntp] Fix webstore toast scroll flicker bug
>
> Fixes a scroll flicker bug and lazy renders the webstore toast.
>
> Bug: 1472228
> Change-Id: Ie462107bb06cb2626aff73a2bb9ed0161fbf0a39
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775458
> Commit-Queue: Roman Arora <romanarora@chromium.org>
> Reviewed-by: Riley Tatum <rtatum@google.com>
> Cr-Commit-Position: refs/heads/main@{#1182639}

(cherry picked from commit a65f0b1)

Bug: 1472228
Change-Id: I99f39e1f324bb977221340168575935591246e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775331
Reviewed-by: Riley Tatum <rtatum@google.com>
Commit-Queue: Riley Tatum <rtatum@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Roman Arora <romanarora@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1183225}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4781451
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#166}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

Roll Chrome Win32 PGO profile from chrome-win32-6367-1711214407-776c0ecb82af2b1afaccd07b7f5c7751ac194550-bcd69c5756b2da77f77384c70b19fec4579cd59b.profdata to chrome-win32-6367-1711229771-628b7254ae1facf091c8bd6b01632a3b06ceed54-5732af2c7bbd5ea15d8f312b7e3790d326eab3c6.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ief738fb80d8b514ec75ebfd1a975509cc78f1162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390347
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#166}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Automatic update for 2024-04-20 UTC

Change-Id: Id98e6f74f4b35d94125afa4b93afd8aba57db611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470042
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6422@{#166}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

Automatic update for 2024-05-17 UTC

Change-Id: I24fd72d87b119711edc504e14b0929362a53449a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545289
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6478@{#166}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}

Bitmap captures are expensive, and should only happen when necessary.
Create a mechanism that will watch the model changes of the bottom tab
strip, and send up opaque tokens to the corresponding
ViewResourceAdapter when a new capture is actually useful.

This will allow us only capture when something material has changed,
as well as not capture when we transition across multiple materially
different states but end up in the state the most recent capture was
also in.

To do this we need an efficient way to compare favicon objects.
However they are composed of Drawables that wrap images that come from
the C++ side, and are different actual objects. To ensure these
comparison are efficient, added identifying metadata to the favicon
objects on the Java side to allow comparisons that do not involve
comparing pixels.

(cherry picked from commit 806638c)

Bug: 1351477
Change-Id: Ia46d521014e18fb7c93952c7381916e750d2d5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820625
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1038454}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3859769
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{chromium#166}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}